[webkit-reviews] review granted: [Bug 49840] GraphicsContext: Make drawFocusRing() take a Path instead of a Vector<Path> : [Attachment 74491] Proposed patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 49840: GraphicsContext: Make drawFocusRing() take a Path instead of a
Vector<Path>
https://bugs.webkit.org/show_bug.cgi?id=49840

Attachment 74491: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=74491&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74491&action=review

> WebCore/platform/graphics/mac/GraphicsContextMac.mm:62
> +    // FIXME: Use 'offset' for something?

Can you file a bug first, and reference the bug id here?

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:805
> +    // FIXME: Use 'width' and 'offset' for something?

Can you file a bug first, and reference the bug id here?