[webkit-reviews] review requested: [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument : [Attachment 74492] Proposed patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 20 19:10:38 PST 2010


Andreas Kling <kling at webkit.org> has asked  for review:
Bug 48516: GraphicsContext: Remove "current path" and have strokePath, fillPath
and clipPath take a Path argument
https://bugs.webkit.org/show_bug.cgi?id=48516

Attachment 74492: Proposed patch v3
https://bugs.webkit.org/attachment.cgi?id=74492&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Rebased on trunk. No code changes since last time.

> Has this patch been performance tested?

Yes, on Qt. It improves performance for us (nothing to write home about, but a
measurable progression), since we avoid a bunch of work maintaining transforms
etc. The same should eventually be true for everyone but CG, since we're all
emulating the "current path" concept.

People with port-specific knowledge may need to come in after this lands and
tweak whatever's appropriate for their GraphicsContext implementation though.
That will mostly consist of removing code.


More information about the webkit-reviews mailing list