[webkit-reviews] review granted: [Bug 42887] [Qt] Search input field doesn't have cancel button : [Attachment 72211] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 20 18:03:44 PST 2010
Andreas Kling <kling at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 42887: [Qt] Search input field doesn't have cancel button
https://bugs.webkit.org/show_bug.cgi?id=42887
Attachment 72211: Patch
https://bugs.webkit.org/attachment.cgi?id=72211&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72211&action=review
r=me
> WebKit/qt/Api/qwebsettings.cpp:106
> + hash->insert(QWebSettings::SearchCancelButtonGraphic,
QApplication::style()->standardPixmap(QStyle::SP_DialogCloseButton));
> + hash->insert(QWebSettings::SearchCancelButtonPressedGraphic,
QApplication::style()->standardPixmap(QStyle::SP_DialogCloseButton));
Not a huge fan of the standardPixmap()s, but it's not a big deal, we can put
some custom ones in later.
> WebKit/qt/Api/qwebsettings.cpp:380
> + \value SearchCancelButtonGraphic The graphic shown for clearing the text
in a search field.
> + \value SearchCancelButtonPressedGraphic The graphic shown when
SearchCancelButtonGraphic is pressed.
FYI: These additions will be subject to API review (scheduled for next week.)
More information about the webkit-reviews
mailing list