[webkit-reviews] review granted: [Bug 49432] Support JIT_OPTIMIZE_MOD on Thumb-2 : [Attachment 74486] Support JIT_OPTIMIZE_MOD on Thumb-2

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Gabor Loki
<loki at webkit.org>'s request for review:
Bug 49432: Support JIT_OPTIMIZE_MOD on Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=49432

Attachment 74486: Support JIT_OPTIMIZE_MOD on Thumb-2
https://bugs.webkit.org/attachment.cgi?id=74486&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Looks awesome Loki.  Just spotted that:
> #error "JIT_OPTIMIZE_MOD not yet supported on this platform."
should now be
> #error "JIT_USE_SOFT_MODULO not yet supported on this platform."
but that's my bad from an earlier change, and won't hold your patch up further
for this – will fix later.