[webkit-reviews] review granted: [Bug 49857] Keep overlap testing logic until real 3d transforms are being used : [Attachment 74483] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 20 10:48:52 PST 2010
mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 49857: Keep overlap testing logic until real 3d transforms are being used
https://bugs.webkit.org/show_bug.cgi?id=49857
Attachment 74483: Patch
https://bugs.webkit.org/attachment.cgi?id=74483&action=review
------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=74483&action=review
> WebCore/rendering/RenderLayerCompositor.cpp:1290
> + RenderStyle* style = renderer->style();
Useless variable!
> WebCore/rendering/RenderLayerCompositor.cpp:1294
> + TransformationMatrix* transform =
toRenderBoxModelObject(renderer)->layer()->transform();
I think this one is unnecessary too.
More information about the webkit-reviews
mailing list