[webkit-reviews] review granted: [Bug 49863] FilterPrimitives should have a pointer to its Filter object : [Attachment 74479] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 49863: FilterPrimitives should have a pointer to its Filter object
https://bugs.webkit.org/show_bug.cgi?id=49863

Attachment 74479: Patch
https://bugs.webkit.org/attachment.cgi?id=74479&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74479&action=review

Great to see progress! The patch looks good. r=me

Just one note:

> WebCore/platform/graphics/filters/FEDisplacementMap.cpp:112
> +    float scaleX = filter()->applyHorizontalScale(m_scale / 255);
> +    float scaleY = filter()->applyVerticalScale(m_scale / 255);
> +    float scaleAdjustmentX = filter()->applyHorizontalScale(0.5f - 0.5f *
m_scale);
> +    float scaleAdjustmentY = filter()->applyVerticalScale(0.5f - 0.5f *
m_scale);
>      int stride = imageRect.width() * 4;

Can you store them in a local var? Filter* filter = this->filter() ? The same
on several other places where you call filter() multiple times.