[webkit-reviews] review denied: [Bug 49491] [Qt] Path fill lacks blur shadow support : [Attachment 74445] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Helder Correia
<helder at sencha.com>'s request for review:
Bug 49491: [Qt] Path fill lacks blur shadow support
https://bugs.webkit.org/show_bug.cgi?id=49491

Attachment 74445: Patch
https://bugs.webkit.org/attachment.cgi?id=74445&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74445&action=review

Looks good, except one thing:

> WebCore/platform/graphics/qt/GraphicsContextQt.cpp:550
> +	       QPainter* shadowPainter = shadow->beginShadowLayer(p,
path.boundingRect());

QPainterPath::boundingRect() is slow, you should use the controlPointRect()
trick here since you only need an approximation.