[webkit-reviews] review granted: [Bug 49848] Make it possible to display the last character of a secure text field unobscured : [Attachment 74451] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 49848: Make it possible to display the last character of a secure text
field unobscured
https://bugs.webkit.org/show_bug.cgi?id=49848

Attachment 74451: Patch
https://bugs.webkit.org/attachment.cgi?id=74451&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74451&action=review

> JavaScriptCore/wtf/text/StringImpl.cpp:277
> +    if (m_length) {

I think it would be better to say:

    if (!m_length)
	return this;

At the start of the function, even before the createUninitialized call.

> JavaScriptCore/wtf/text/StringImpl.cpp:278
> +	   const unsigned lastCharacterIndex = m_length - 1;

We normally don’t use const for local variables like this one.