[webkit-reviews] review requested: [Bug 49848] Make it possible to display the last character of a secure text field unobscured : [Attachment 74451] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 19 18:03:22 PST 2010


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 49848: Make it possible to display the last character of a secure text
field unobscured
https://bugs.webkit.org/show_bug.cgi?id=49848

Attachment 74451: Patch
https://bugs.webkit.org/attachment.cgi?id=74451&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* JavaScriptCore.exp:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::secure): Added argument that controls whether
the last character is obscured or not.	Implemented behavior.
* wtf/text/StringImpl.h:
(WTF::StringImpl::LastCharacterBehavior): Added enum.
(WTF::StringImpl::secure): Updated method signature.
---
 4 files changed, 26 insertions(+), 5 deletions(-)


More information about the webkit-reviews mailing list