[webkit-reviews] review granted: [Bug 49819] Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files : [Attachment 74430] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 19 16:58:13 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 49819: Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for
all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

Attachment 74430: Patch
https://bugs.webkit.org/attachment.cgi?id=74430&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74430&action=review

> WebKit2/win/WebKit2WebProcessCommon.vsprops:14
>		AdditionalDependencies="WebKit$(WebKitDLLConfigSuffix).lib"
> +    AdditionalOptions="/NXCOMPAT"

Screwy indentation here.

> WebKit/win/WebKit.vcproj/WebKitGUID.vcproj:252
> +				Name="VCMIDLTool"
> +				OutputDirectory="Release"

Is the OutputDirectory needed?


More information about the webkit-reviews mailing list