[webkit-reviews] review requested: [Bug 48110] getBoundingClientRect: Do not truncate the coordinates to integers : [Attachment 74442] Fix and layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 19 16:50:48 PST 2010


Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 48110: getBoundingClientRect: Do not truncate the coordinates to integers
https://bugs.webkit.org/show_bug.cgi?id=48110

Attachment 74442: Fix and layout tests
https://bugs.webkit.org/attachment.cgi?id=74442&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
(In reply to comment #22)
> It would be great, if you would warn the user if anyone tries to execute the
tests in a non-DRT environment (eg. in Safari) and replace all SKIP usages by
shouldBe(...). Then you also don't need to dump the actual results in the
expecaction files.

Done.
I now realized that possible failures may accidentally end up under the radar,
if they occur at a time when tests are being rebaselined. So it's a good thing
that you insisted.

> Thanks for you hard work!

This one wasn't really that hard, but thank you for your appreciation :-)


More information about the webkit-reviews mailing list