[webkit-reviews] review canceled: [Bug 49813] SelectionController::typingStyle() should return EditingStyle* : [Attachment 74407] refactoring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 19 12:10:39 PST 2010


Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 49813: SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813

Attachment 74407: refactoring
https://bugs.webkit.org/attachment.cgi?id=74407&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #3)
> (In reply to comment #2)
> > Attachment 74407 [details] [details] did not build on mac:
> > Build output: http://queues.webkit.org/results/6230070
> 
> /Projects/MacEWS/WebKit/mac/WebView/WebFrame.mm: In function
'DOMCSSStyleDeclaration* -[WebFrame(WebInternal) _typingStyle](WebFrame*,
objc_selector*)':
> /Projects/MacEWS/WebKit/mac/WebView/WebFrame.mm:906: error: 'class
WebCore::EditingStyle' has no member named 'copy'

I'm on it.  I'll fix and upload again.


More information about the webkit-reviews mailing list