[webkit-reviews] review granted: [Bug 49768] nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread : [Attachment 74335] review feedback - sort imports alphabetically

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49768: nrwt multiprocessing - add 'worker number' concept, move stuff to
worker thread
https://bugs.webkit.org/show_bug.cgi?id=49768

Attachment 74335: review feedback - sort imports alphabetically
https://bugs.webkit.org/attachment.cgi?id=74335&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74335&action=review

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d.py:171
> +    def __init__(self, port, options, worker_number, worker_name,
> +		    test_input, test_types, test_args):

My main concern with having a separate name and number is that it makes
functions with lots of parameters fragile.  Since there's no compile time
checking of parameters, it's easy to miss a caller and break things when
refactoring.

In this case, it's relatively isolated (only this call takes both), so I don't
feel that strongly about it.  This patch doesn't use worker_number, do you need
it in the future?  Maybe it should be added when it's used?