[webkit-reviews] review denied: [Bug 49748] [Qt] Compile with QT_NO_SCRIPT : [Attachment 74257] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Sam Magnuson
<smagnuso at gmail.com>'s request for review:
Bug 49748: [Qt] Compile with QT_NO_SCRIPT
https://bugs.webkit.org/show_bug.cgi?id=49748

Attachment 74257: Patch
https://bugs.webkit.org/attachment.cgi?id=74257&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
I do not think we can accept changes (with no proper build guards) that are
relying on an unapproved/unreleased version of Qt API. We might be able to
revisit this after the underlying Qt API is released.

In addition we have plans to unify the QtScript engine with the engine used by
QtWebKit. Once these plans realize maintaining the QT_NO_SCRIPT configuration
for QtWebKit will no longer make sense. 

Can you perhaps maintain these changes on your private branch instead of
upstreaming them to the trunk ? 

r- as with our current processing, this commit would break the build.