[webkit-reviews] review denied: [Bug 49727] Web Inspector: [Chromium] Expose extension API to select a node in WebInspector : [Attachment 74231] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 49727: Web Inspector: [Chromium] Expose extension API to select a node in
WebInspector
https://bugs.webkit.org/show_bug.cgi?id=49727

Attachment 74231: patch
https://bugs.webkit.org/attachment.cgi?id=74231&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74231&action=review

> WebKit/chromium/src/WebDevToolsExtensionImpl.cpp:95
> +    "chrome = chrome || {};"

WebKit should not be modifying "window.chrome"

That belongs to Chromium, and we setup that in chrome/renderer.
Perhaps you should move this extension there?

Also, WebKit/chromium/src is not the place to be defining "web platform APIs."
That should be done in WebCore.  The only exception is window.chrome, which is
for UA specific things, and therefore does not belong in the WebKit repository.