[webkit-reviews] review denied: [Bug 49787] QtWebKit does not respond properly to QInputMethodEvents with replacement text in them. : [Attachment 74377] Patch for WebKit trunk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 19 06:43:13 PST 2010


Andreas Kling <kling at webkit.org> has denied Kristian Amlie
<kristian.amlie at nokia.com>'s request for review:
Bug 49787: QtWebKit does not respond properly to QInputMethodEvents with
replacement text in them.
https://bugs.webkit.org/show_bug.cgi?id=49787

Attachment 74377: Patch for WebKit trunk
https://bugs.webkit.org/attachment.cgi?id=74377&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74377&action=review

> WebKit/qt/Api/qwebpage.cpp:1091
> +    } else if (!ev->commitString().isEmpty()) {

Coding style, no { } for single-line blocks.

> WebKit/qt/ChangeLog:11
> +	Also made sure that the preeditString is always respected, even if
> +	there is committed text. This is how QLineEdit does it.

Use spaces for indentation.


More information about the webkit-reviews mailing list