[webkit-reviews] review granted: [Bug 49776] Windows vcproj configuration names should be normalized across projects : [Attachment 74334] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 49776: Windows vcproj configuration names should be normalized across
projects
https://bugs.webkit.org/show_bug.cgi?id=49776

Attachment 74334: Patch
https://bugs.webkit.org/attachment.cgi?id=74334&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74334&action=review

>
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcp
roj:48
> -			       
BuildCommandLine="%SystemDrive%\cygwin\bin\which.exe bash&#x0D;&#x0A;if
errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%&#x0D;&#x0A;cmd
/c&#x0D;&#x0A;&#x0D;&#x0A;nmake /nologo -f JavaScriptCoreGenerated.make"
> -			       
ReBuildCommandLine="%SystemDrive%\cygwin\bin\which.exe bash&#x0D;&#x0A;if
errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%&#x0D;&#x0A;cmd
/c&#x0D;&#x0A;&#x0D;&#x0A;nmake /nologo -f JavaScriptCoreGenerated.make
clean&#x0D;&#x0A;nmake -f JavaScriptCoreGenerated.make"
> -			       
CleanCommandLine="%SystemDrive%\cygwin\bin\which.exe bash&#x0D;&#x0A;if
errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%&#x0D;&#x0A;cmd
/c&#x0D;&#x0A;&#x0D;&#x0A;nmake /nologo -f JavaScriptCoreGenerated.make clean"
> -				Output=""
> -				PreprocessorDefinitions="WIN32;NDEBUG"
> -				IncludeSearchPath=""
> -				ForcedIncludes=""
> -				AssemblySearchPath=""
> -				ForcedUsingAssemblies=""
> -				CompileAsManaged=""
>			/>

Where did this code go?

> WebCore/WebCore.vcproj/WebCoreGeneratedCairo.vsprops:9
> +		BuildCommandLine="%SystemDrive%\cygwin\bin\which.exe
bash&#x0D;&#x0A;if errorlevel 1 set
PATH=%SystemDrive%\cygwin\bin;%PATH%&#x0D;&#x0A;cmd /c&#x0D;&#x0A;if exist
&quot;$(WebKitOutputDir)\buildfailed&quot; grep XX$(ProjectName)XX
&quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;if errorlevel 1 exit
1&#x0D;&#x0A;echo XX$(ProjectName)XX &gt;
&quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;&#x0D;&#x0A;bash
build-generated-files.sh &quot;$(WebKitOutputDir)&quot;
&quot;$(WebKitLibrariesDir)&quot; cairo&#x0D;&#x0A;bash migrate-scripts.sh
&quot;$(WebKitOutputDir)/obj/WebCore/scripts&quot;&#x0D;&#x0A;cmd /C
copyForwardingHeaders.cmd cairo curl&#x0D;&#x0A;cmd /C
copyInspectorFiles.cmd&#x0D;&#x0A;&#x0D;&#x0A;if exist
&quot;$(WebKitOutputDir)\buildfailed&quot; del
&quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;"

Maybe we could abstract the Apple vs. Cairo differences using a macro?

> WebCore/WebCore.vcproj/WebCoreGeneratedCairo.vsprops:18
> +		CleanCommandLine=""
> +		Output=""
> +		PreprocessorDefinitions=""
> +		IncludeSearchPath=""
> +		ForcedIncludes=""
> +		AssemblySearchPath=""
> +		ForcedUsingAssemblies=""
> +		CompileAsManaged=""

Are these needed?A

> WebCore/WebCore.vcproj/WebCoreGeneratedCommon.vsprops:20
> +		Output=""
> +		PreprocessorDefinitions=""
> +		IncludeSearchPath=""
> +		ForcedIncludes=""
> +		AssemblySearchPath=""
> +		ForcedUsingAssemblies=""
> +		CompileAsManaged=""

Are these needed?

> WebKit2/win/WebKit2GeneratedCommon.vsprops:20
> +		Output=""
> +		PreprocessorDefinitions=""
> +		IncludeSearchPath=""
> +		ForcedIncludes=""
> +		AssemblySearchPath=""
> +		ForcedUsingAssemblies=""
> +		CompileAsManaged=""

Are these needed?

> WebKitTools/TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:18
> +		Output=""
> +		PreprocessorDefinitions=""
> +		IncludeSearchPath=""
> +		ForcedIncludes=""
> +		AssemblySearchPath=""
> +		ForcedUsingAssemblies=""
> +		CompileAsManaged=""

Are these needed?

> WebKitTools/WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:20
> +		Output=""
> +		PreprocessorDefinitions=""
> +		IncludeSearchPath=""
> +		ForcedIncludes=""
> +		AssemblySearchPath=""
> +		ForcedUsingAssemblies=""
> +		CompileAsManaged=""

Are these needed?