[webkit-reviews] review canceled: [Bug 48110] getBoundingClientRect: Do not truncate the coordinates to integers : [Attachment 74204] Fix and layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 21:45:37 PST 2010


Cosmin Truta <ctruta at chromium.org> has canceled Cosmin Truta
<ctruta at chromium.org>'s request for review:
Bug 48110: getBoundingClientRect: Do not truncate the coordinates to integers
https://bugs.webkit.org/show_bug.cgi?id=48110

Attachment 74204: Fix and layout tests
https://bugs.webkit.org/attachment.cgi?id=74204&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
(In reply to comment #19)
> Ok, new suggestion: Use the "Ahem" font, that should give you exactly the
same results on all platforms (hopefully). Text will appear as black blocks
(rects), all of the same width/height and advance.
> Can you give that another try?

I did, it worked, thanks for the suggestion. One thing that I found convenient
is that I no longer need two -expected files for each of the two test cases.

But I still see a virtue in not having the font-dependent coordinates hardcoded
in the HTML source: in the moment when I loaded the HTML in the browser, my
first instinct was, oh! now there are FAILures!
In fact, everything was fine. It was the browser just showing the regular font
(thus producing the errors), while the tests are now run using the Ahem font.

> I'd love to avoid SKIP ... messages, or not checking something.

But they are still being checked, using the -expected file.

One of the following two things should be done: either leave the SKIPs in there
and use the expectation file to check the actual coordinates; or insert a code
snippet that only allows the two tests to run in testshell, so that they don't
look alarming and misleadingly incorrect in the browser. In my latest patch, I
did the former, because I think that loading the HTML tests in the browser is
useful. However, if you still want me to do the latter, please tell me, and
I'll resubmit.


More information about the webkit-reviews mailing list