[webkit-reviews] review denied: [Bug 49765] [Qt] Memory leak in QWebInspector : [Attachment 74306] prevent double delete by QWebPagePrivate

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 49765: [Qt] Memory leak in QWebInspector
https://bugs.webkit.org/show_bug.cgi?id=49765

Attachment 74306: prevent double delete by QWebPagePrivate
https://bugs.webkit.org/attachment.cgi?id=74306&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74306&action=review

Patch is fine, but:

> WebKit/qt/Api/qwebinspector.cpp:94
> +    if (d) {

Unnecessary if- "delete d" is a no-op if !d.

> WebKit/qt/Api/qwebinspector.cpp:96
> +	   // Prevent double delete by QWebPagePrivate

Unnecessary comment.