[webkit-reviews] review granted: [Bug 17653] CSSRuleSet should be moved out of CSSStyleSelector.cpp into its own files : [Attachment 74337] Extracted CSSRuleSet.h and CSSRuleSet.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 20:19:08 PST 2010


Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 17653: CSSRuleSet should be moved out of CSSStyleSelector.cpp into its own
files
https://bugs.webkit.org/show_bug.cgi?id=17653

Attachment 74337: Extracted CSSRuleSet.h and CSSRuleSet.cpp
https://bugs.webkit.org/attachment.cgi?id=74337&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74337&action=review

LGTM, assuming you're not changing any logic (just moving) and you have an
answer for the perf question.

> WebCore/css/CSSRuleSet.cpp:43
> +: m_ruleCount(0)
> +, m_pageRuleCount(0)

I think we normally indent these.


More information about the webkit-reviews mailing list