[webkit-reviews] review denied: [Bug 44064] GraphicsContext3D::reshape is clearing using current clear color instead of transparent : [Attachment 74318] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 44064: GraphicsContext3D::reshape is clearing using current clear color
instead of transparent
https://bugs.webkit.org/show_bug.cgi?id=44064

Attachment 74318: patch
https://bugs.webkit.org/attachment.cgi?id=74318&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74318&action=review

Looks good. Apologies but we decided to change the clear depth upon resizing to
the default value (1.0) rather than 0.0 on today's WebGL conference call, so
would appreciate it if you could fix that up in these changes.

> WebCore/platform/graphics/gpu/DrawingBuffer.cpp:183
> +	   m_context->clearDepth(0);

Per discussion on today's WebGL conference call, we should use the default
clear depth, which is 1.0. The spec's been updated with this change.

> WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:227
> +	   ::glClearDepth(0);

Here too.

> WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:455
> +	   glClearDepth(0);

Here too.