[webkit-reviews] review denied: [Bug 49768] nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread : [Attachment 74321] minor cleanup

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49768: nrwt multiprocessing - add 'worker number' concept, move stuff to
worker thread
https://bugs.webkit.org/show_bug.cgi?id=49768

Attachment 74321: minor cleanup
https://bugs.webkit.org/attachment.cgi?id=74321&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74321&action=review

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d.py:55
> +from webkitpy.layout_tests.test_types import test_type_base
> +from webkitpy.layout_tests.test_types import text_diff
> +from webkitpy.layout_tests.test_types import image_diff

Nit: Sort alphabetically

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d.py:486
> +				     self._worker_number,
> +				     self._name,

It seems redundant to have to pass worker number and worker name.  Are there
cases where you can't derive the name from the number?	Maybe there should just
be a static function somewhere that converts number to name?