[webkit-reviews] review denied: [Bug 49630] Move Position::EditingBoundaryCrossingRule to a new header file : [Attachment 74051] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 17:27:54 PST 2010


Tony Chang <tony at chromium.org> has denied kalman at chromium.org's request for
review:
Bug 49630: Move Position::EditingBoundaryCrossingRule to a new header file
https://bugs.webkit.org/show_bug.cgi?id=49630

Attachment 74051: Patch
https://bugs.webkit.org/attachment.cgi?id=74051&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74051&action=review

You also want to add the new file to the various build files: GNUmakefile.am,
WebCore.gypi, WebCore.pro, WebCore.vcproj/WebCore.vcproj, and
WebCore.xcodeproj/project.pbxproj.  I think it won't compile if you don't add
it to the xcode project.

> WebCore/editing/EditingBoundary.h:43
> +#endif /* EditingBoundary_h */

The comment should be //, not /* */


More information about the webkit-reviews mailing list