[webkit-reviews] review denied: [Bug 49635] Profiler implementation is fragile : [Attachment 74308]=?UTF-8?Q?=20New=20improved=20implementation=20=E2=80=93=C2=A0breaks=20no=20tests?=, even fixes one!

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 49635: Profiler implementation is fragile
https://bugs.webkit.org/show_bug.cgi?id=49635

Attachment 74308: New improved implementation – breaks no tests, even fixes
one!
https://bugs.webkit.org/attachment.cgi?id=74308&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74308&action=review

> JavaScriptCore/interpreter/Interpreter.cpp:566
> +//	 if (Profiler* profiler = *Profiler::enabledProfilerReference()) {
> +//	     if (callFrame->callee())
> +//		 profiler->didExecute(callFrame, callFrame->callee());
> +//	     else
> +//		 profiler->didExecute(callFrame,
codeBlock->ownerExecutable()->sourceURL(),
codeBlock->ownerExecutable()->lineNo());
> +//	 }

really?