[webkit-reviews] review granted: [Bug 49762] Stylesheet wrappers are not GC protected : [Attachment 74303] proposed fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 49762: Stylesheet wrappers are not GC protected
https://bugs.webkit.org/show_bug.cgi?id=49762

Attachment 74303: proposed fix
https://bugs.webkit.org/attachment.cgi?id=74303&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
>From a GC footprint perspective, the approach here isn't ideal, since, as you
say in your FIXME, we might artificially keep alive style wrappers we could
have thrown away.

However, I expect that the set of all style-related DOM nodes in a document is
quite small in practice -- and often these nodes aren't even wrapped by JS --
so in these cases I think this approach is fine.