[webkit-reviews] review denied: [Bug 49744] Undo moves caret to invalid position : [Attachment 74293] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Levi Weintraub <leviw at google.com>'s
request for review:
Bug 49744: Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744

Attachment 74293: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=74293&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74293&action=review

> WebCore/rendering/RenderBox.cpp:2926
> -    // FIXME: What about border and padding?
> -    IntRect rect(x(), y(), caretWidth, height());
> +    IntRect rect(x() + borderLeft() + paddingLeft(), y() + borderTop() +
paddingTop(), caretWidth, height());
>      bool ltr = box ? box->isLeftToRightDirection() :
style()->isLeftToRightDirection();

This won’t do the right thing in RTL cases. We need RTL coverage in a test
case, and code that adds the appropriate right side border and padding.

> LayoutTests/editing/selection/caret-painting-after-paste-undo.html:22
>  \ No newline at end of file

Normally we put newlines at the ends of files like this one.