[webkit-reviews] review denied: [Bug 49707] new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes : [Attachment 74195] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 49707: new-run-webkit-tests: create first part of 'message_broker' class
for multiprocessing fixes
https://bugs.webkit.org/show_bug.cgi?id=49707

Attachment 74195: Patch
https://bugs.webkit.org/attachment.cgi?id=74195&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74195&action=review

Just some small nits

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d_unittest.py:35
> +    pass

Should we just delete this file for now?  It's easy to bring back.

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py:34

> +

Nit: Kill blank line?

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py:38

> +# FIXME: This is a small file for now to handle breaking the uber-patch into

> +# smaller, more manageable patches.

I don't understand what needs to be fixed here.  I think it's fine to have
small .py files.  I would just remove this comment.