[webkit-reviews] review requested: [Bug 49693] REGRESSION(71884): Crash when installing extension that references safari-extension URL : [Attachment 74280] patch + test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 13:02:41 PST 2010


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 49693: REGRESSION(71884): Crash when installing extension that references
safari-extension URL
https://bugs.webkit.org/show_bug.cgi?id=49693

Attachment 74280: patch + test
https://bugs.webkit.org/attachment.cgi?id=74280&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
It's a pretty simple fix.  If we start the load, then remove the ResourceLoader
from the queue after, it might have been cancelled and already removed from the
queue (causing a crash if the queue is now empty).  Instead, we should remove
the ResourceLoader from the queue before starting it.


More information about the webkit-reviews mailing list