[webkit-reviews] review denied: [Bug 49106] Include the FrameView widget of a RenderWidget in the accessibility tree. : [Attachment 73921] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 11:06:31 PST 2010


chris fleizach <cfleizach at apple.com> has denied chris.guillory at google.com's
request for review:
Bug 49106: Include the FrameView widget of a RenderWidget in the accessibility
tree.
https://bugs.webkit.org/show_bug.cgi?id=49106

Attachment 73921: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=73921&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=73921&action=review

some small changes

can you file a Mac bug asking to revisit why Mac can't use this code (and
assign to me, and relate to this)

> WebCore/accessibility/AccessibilityRenderObject.cpp:3383
> +#endif

can you put this in a method like,

appendWidgetChildren or something

> WebCore/accessibility/chromium/AccessibilityObjectChromium.cpp:37
> +    // Ignore iframe renderers that have a content renderer.

can you explain why you're ignoring content renderers here. this comment states
what the code does, but not why


More information about the webkit-reviews mailing list