[webkit-reviews] review granted: [Bug 49711] WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings : [Attachment 74201] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 18 09:10:00 PST 2010
Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 49711: WebKitTools projects (WebKitTestRunner, record-memory-win) should
use vsprops for common build settings
https://bugs.webkit.org/show_bug.cgi?id=49711
Attachment 74201: Patch
https://bugs.webkit.org/attachment.cgi?id=74201&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74201&action=review
> WebKitTools/WebKitTestRunner/win/WebKitTestRunner.vcproj:265
> OutputDirectory="$(SolutionDir)$(ConfigurationName)"
> IntermediateDirectory="$(ConfigurationName)"
You should remove these while you're in here.
> WebKitTools/WebKitTestRunner/win/WebKitTestRunner.vcproj:328
> OutputDirectory="$(SolutionDir)$(ConfigurationName)"
> IntermediateDirectory="$(ConfigurationName)"
And these.
More information about the webkit-reviews
mailing list