[webkit-reviews] review granted: [Bug 49729] Web Inspector: reduce the footprint of InspectorBackendDispatcher. : [Attachment 74234] [patch] initial version.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 06:59:46 PST 2010


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 49729: Web Inspector: reduce the footprint of InspectorBackendDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=49729

Attachment 74234: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=74234&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74234&action=review

> WebCore/ChangeLog:6
> +	   InspectorBackendDispatcher is a generated file.

Please provide a meaningful change log entry describing the change details.

> WebCore/inspector/CodeGeneratorInspector.pm:354
> +	       $typeString =~ s/\b(\w)/\U$1/g;

Please comment these two lines.


More information about the webkit-reviews mailing list