[webkit-reviews] review requested: [Bug 25770] Possible Crash in FontFallbackList::determinePitch(const Font* font)? : [Attachment 74209] A copy-and-paste fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 18 00:00:38 PST 2010


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 25770: Possible Crash in FontFallbackList::determinePitch(const Font*
font)?
https://bugs.webkit.org/show_bug.cgi?id=25770

Attachment 74209: A copy-and-paste fix
https://bugs.webkit.org/attachment.cgi?id=74209&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,

This change just copied some font-fallback code from
"WebCore/platform/graphics/win/FontCacheWin.cpp" to
"WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp" to fix this
Chromium crash. (As far as I tested with my reproduction steps, this change
fixes this crash.) Unfortunately, I do not have any ideas how to write a layout
test for this crash because it happens only on a PC that do not have some
system fonts corrupted.

Regards,

Hironori Bono


More information about the webkit-reviews mailing list