[webkit-reviews] review denied: [Bug 26083] How to access formatted Java script Console message ? : [Attachment 74128] Fixed build issues and took care of review comments

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Gopal Raghavan
<gopal.1.raghavan at nokia.com>'s request for review:
Bug 26083: How to access formatted Java script Console message ?
https://bugs.webkit.org/show_bug.cgi?id=26083

Attachment 74128: Fixed build issues and took care of review comments
https://bugs.webkit.org/attachment.cgi?id=74128&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
The patch adds direct dependencies to JavaScriptCore (e.g. PropertyNameArray.h)
from within port-independent WebCore without any guards. This makes the
Chromium bot fail as Chromium is using V8.

There are classes available that abstract V8 and JavaScriptCore for WebCore and
are available to stringify JavaScript values. Check if the ScriptValue
interface would work here - you might find toString() and toInspectorValue()
useful.

CCing Yury and Pavel for their help/input.

r- as I think the functionality of the makeStringFromObj() function should be
implemented for V8 as well.