[webkit-reviews] review granted: [Bug 49700] XSLTProcessor.importNode is only tested with document nodes, and hits an assertion : [Attachment 74181] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 22:50:32 PST 2010


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 49700: XSLTProcessor.importNode is only tested with document nodes, and
hits an assertion
https://bugs.webkit.org/show_bug.cgi?id=49700

Attachment 74181: proposed fix
https://bugs.webkit.org/attachment.cgi?id=74181&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74181&action=review

> WebCore/css/CSSStyleSheet.cpp:50
> +#if ENABLE(SVG)
> +	   || parentNode->hasTagName(SVGNames::styleTag)
> +#endif    

If you moved this expression up one line so it was next to the HTML style tag,
then you could use a more-normal semicolon-on-end-of-line.


More information about the webkit-reviews mailing list