[webkit-reviews] review requested: [Bug 49672] Allow no-store resources to be used for back navigation : [Attachment 74193] [PATCH] Do No Mark "https" Resources as Allowed For History

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 19:01:00 PST 2010


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 49672: Allow no-store resources to be used for back navigation
https://bugs.webkit.org/show_bug.cgi?id=49672

Attachment 74193: [PATCH] Do No Mark "https" Resources as Allowed For History
https://bugs.webkit.org/attachment.cgi?id=74193&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
• Addressed Darin's comments and made renames.
• Do not mark https resources for history, just remove them like we used to.

Correct me if I am wrong, but I don't need to check if the main resource is
https, just
the "no-cache" subresource. I thought about this for a while, and I figured
that if a
sub-resource is non-secure inside a secure main resource, then the subresource
is
not particularly important.

I have "Reviewed by Darin" in the patch, but I will replace that after another
review.
I just forgot to change it back to OOPS.


More information about the webkit-reviews mailing list