[webkit-reviews] review granted: [Bug 47196] Implement UNPACK_COLORSPACE_CONVERSION_WEBGL : [Attachment 74184] patch: hooking up COLORSPACE_CONVERSION setting with ICC profile behavior

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 17:45:56 PST 2010


Adam Barth <abarth at webkit.org> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 47196: Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

Attachment 74184: patch: hooking up COLORSPACE_CONVERSION setting with ICC
profile behavior
https://bugs.webkit.org/attachment.cgi?id=74184&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74184&action=review

Thanks.  Please address the comments below before landing.

> WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:247
> -	       m_decoder->setColorProfile(readColorProfile(info()));	       
  
> +	       if (m_decoder->ignoresGammaAndColorProfile())
> +		   m_decoder->setColorProfile(ColorProfile());
> +	       else
> +		   m_decoder->setColorProfile(readColorProfile(info()));

You don't need to call setColorProfile if you want the default..

> WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:269
> -    if (colorType == PNG_COLOR_TYPE_RGB || colorType ==
PNG_COLOR_TYPE_RGB_ALPHA) {
> +    if ((colorType == PNG_COLOR_TYPE_RGB || colorType ==
PNG_COLOR_TYPE_RGB_ALPHA)
> +	   && !m_ignoreGammaAndColorProfile) {

One line please.


More information about the webkit-reviews mailing list