[webkit-reviews] review granted: [Bug 49470] [Qt] Static platform plugin support : [Attachment 73772] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 49470: [Qt] Static platform plugin support
https://bugs.webkit.org/show_bug.cgi?id=49470

Attachment 73772: patch
https://bugs.webkit.org/attachment.cgi?id=73772&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=73772&action=review

r=me, but..

> WebKit/qt/ChangeLog:8
> +	   Adding support for static platform pugins.

s/pugins/plugins/

> WebKit/qt/WebCoreSupport/QtPlatformPlugin.h:53
> +    bool loadStaticPlugin();

Not a huge fan of this name.. loadStaticallyLinkedPlugin()?