[webkit-reviews] review requested: [Bug 49503] update-webkit-support-libs should fall back to existing WebKitSupportLibrary version if there is no internet connectivity : [Attachment 74165] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 17 15:42:50 PST 2010
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 49503: update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503
Attachment 74165: Patch
https://bugs.webkit.org/attachment.cgi?id=74165&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch based on Adam Roben's comments.
Renamed $supportLibsURL to $versionFileURL and moved common code to check for
presence of WebKitSupportLibrary.zip and extract its version into method
zipFileVersionOrDieAndInstructToDownload(). I am open to suggestions.
More information about the webkit-reviews
mailing list