[webkit-reviews] review granted: [Bug 49690] DumpRenderTree on Windows should use a vsprops file for shared project settings : [Attachment 74160] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 49690: DumpRenderTree on Windows should use a vsprops file for shared
project settings
https://bugs.webkit.org/show_bug.cgi?id=49690

Attachment 74160: Patch
https://bugs.webkit.org/attachment.cgi?id=74160&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74160&action=review

>
WebKitTools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:41
> +				AdditionalIncludeDirectories=""

Is this harmless? I've been removing it for my own changes.

> WebKitTools/DumpRenderTree/win/DumpRenderTreeCURL.vsprops:9
> +		AdditionalDependencies="libcurl_imp.lib"

I think this whole file isn't needed. You can use
WebKitLibraries/win/tools/vsprops/cURL.vsprops.

> WebKitTools/DumpRenderTree/win/DumpRenderTreeCairo.vsprops:13
> +		AdditionalDependencies="cairo.lib libjpeg.lib libpng.lib"

I think this line isn't needed given that we're already using WinCairo.vsprops.


> WebKitTools/DumpRenderTree/win/ImageDiffCommon.vsprops:14
> +	       
AdditionalDependencies="JavaScriptCore$(WebKitDLLConfigSuffix).lib
CoreGraphics$(LibraryConfigSuffix).lib
CoreFoundation$(LibraryConfigSuffix).lib"

Maybe we should put CG/CF in a ImageDiffApple.vsprops file instead? (Maybe we
should add CG.vsprops and CF.vsprops in WebKitLibraries/win/tools/vsprops?)