[webkit-reviews] review granted: [Bug 49666] [Gtk] "CRITICAL **: msg_got_headers_cb: assertion `entry' failed" when using HTTP cache : [Attachment 74120] Fix for the bug

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 49666: [Gtk] "CRITICAL **: msg_got_headers_cb: assertion `entry' failed"
when using HTTP cache
https://bugs.webkit.org/show_bug.cgi?id=49666

Attachment 74120: Fix for the bug
https://bugs.webkit.org/attachment.cgi?id=74120&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+	  taken that into account by taking the assumption that any possible
taking that into account... making the assumption?
>+	  conditional request was always generated by itself.
>+
>+	  * platform/network/soup/cache/webkit/soup-cache.c:
>+	  (webkit_soup_cache_entry_remove): added an assertion
>+	  (msg_got_headers_cb):
>+

Rest makes sense to me, thanks for tracking it down.