[webkit-reviews] review denied: [Bug 46258] [EFL] Add support for scaling the contents : [Attachment 68367] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Alex Bredariol Grilo
<abgrilo at profusion.mobi>'s request for review:
Bug 46258: [EFL] Add support for scaling the contents
https://bugs.webkit.org/show_bug.cgi?id=46258

Attachment 68367: Patch
https://bugs.webkit.org/attachment.cgi?id=68367&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68367&action=review

Whoa, this one is all over the place.
Please break this up into smaller patches, preferably separating the
EFL-specific changes from the WebCore changes.

> WebCore/platform/ScrollView.cpp:870
> -    context->clip(visibleContentRect());
> +    IntRect visibleRect = visibleContentRect();
> +    context->clip(visibleRect);

What's going on here?

> WebCore/rendering/RenderBoxModelObject.cpp:114
> -    bool contextIsScaled =
!currentTransform.isIdentityOrTranslationOrFlipped();
> +    bool contextIsScaled = false;

Please explain this change.