[webkit-reviews] review granted: [Bug 49672] Allow no-store resources to be used for back navigation : [Attachment 74133] [PATCH] Fixed Typos + Improved Comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 49672: Allow no-store resources to be used for back navigation
https://bugs.webkit.org/show_bug.cgi?id=49672

Attachment 74133: [PATCH] Fixed Typos + Improved Comments
https://bugs.webkit.org/attachment.cgi?id=74133&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74133&action=review

r=me, but you should change some of the names

> WebCore/loader/cache/CachedResource.h:124
> +    bool isHistoryOnly() const { return m_historyOnly; }
> +    void setHistoryOnly(bool b) { m_historyOnly = b; }

Name these isStale() and setStale().

> WebCore/loader/cache/CachedResource.h:260
> +    bool m_historyOnly : 1;

Name this m_isStale.