[webkit-reviews] review denied: [Bug 49431] Refactor TestTypeBase.compare_output(). : [Attachment 74125] merge-tot

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 49431: Refactor TestTypeBase.compare_output().
https://bugs.webkit.org/show_bug.cgi?id=49431

Attachment 74125: merge-tot
https://bugs.webkit.org/attachment.cgi?id=74125&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74125&action=review

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_threa
d.py:96
> +	 test_output: a actual test_output

not sure what "actual" means in this context

> WebKitTools/Scripts/webkitpy/layout_tests/test_types/image_diff.py:94
> +			   expected_test_output):

indentation is off

> WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py:-58
> -    def _get_normalized_expected_text(self, filename):

isn't this still being used below?