[webkit-reviews] review denied: [Bug 49355] WebGLRenderingContext needs to zero textures and renderbuffers : [Attachment 74058] revised patch: fix compile issue for webkit

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 49355: WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

Attachment 74058: revised patch: fix compile issue for webkit
https://bugs.webkit.org/attachment.cgi?id=74058&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74058&action=review

This mostly looks good. Minor code and formatting issues.

> WebCore/html/canvas/WebGLRenderingContext.cpp:2512
> +	   zero.set(new unsigned char[size]);

This should be "zero = adoptArrayPtr(new unsigned char[size]);".

> LayoutTests/fast/canvas/webgl/uninitialized-test.html:75
> +if (data.length != expectedDataLength) {
> +    testFailed("expected data length " + expectedDataLength + " but got " +
data.length + " instead.");
> +} else {
> +    var k = 0;
> +    for (var i = 0; i < data.length; ++i) {
> +	if (data[i] != 0) {
> +	    k++;
> +	}
> +    }
> +
> +    if (k) {
> +	testFailed("Found " + k + " non-zero bytes");
> +    } else {
> +	testPassed("All data initialized");
> +    }
> +}

Indentation is very messed up.