[webkit-reviews] review granted: [Bug 49627] [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser : [Attachment 74118] proposed patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 17 09:03:48 PST 2010
Andreas Kling <kling at webkit.org> has granted Andras Becsi <abecsi at webkit.org>'s
request for review:
Bug 49627: [Qt][WK2] Make it possible to set custom user agent strings in
MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=49627
Attachment 74118: proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=74118&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74118&action=review
LGTM, just one thing:
> WebKitTools/MiniBrowser/qt/BrowserWindow.cpp:141
> + ASSERT(!m_userAgentList.isEmpty());
Use Q_ASSERT instead and remove the WTF include + JavaScriptCore path in .pro
More information about the webkit-reviews
mailing list