[webkit-reviews] review requested: [Bug 49666] [Gtk] "CRITICAL **: msg_got_headers_cb: assertion `entry' failed" when using HTTP cache : [Attachment 74120] Fix for the bug

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has asked  for review:
Bug 49666: [Gtk] "CRITICAL **: msg_got_headers_cb: assertion `entry' failed"
when using HTTP cache
https://bugs.webkit.org/show_bug.cgi?id=49666

Attachment 74120: Fix for the bug
https://bugs.webkit.org/attachment.cgi?id=74120&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
The assumption was wrong. We were assuming that the HTTP cache was the only one
generating conditional requests to the server for its cached resources.

WebKit has its own in memory resource cache. It is capable of detecting when a
resource needs to be revalidated and thus it can create conditional requests by
itself. The problem was that the cache code was not considering that
possibility, cache clients should be allowed to issue their own conditional
requests. In those cases the cache should not do anything special, just return
the resource as provided by libsoup.