[webkit-reviews] review granted: [Bug 49640] Rebaseline server: compute diffs client-side : [Attachment 74078] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 17 08:53:36 PST 2010
Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 49640: Rebaseline server: compute diffs client-side
https://bugs.webkit.org/show_bug.cgi?id=49640
Attachment 74078: Patch
https://bugs.webkit.org/attachment.cgi?id=74078&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74078&action=review
> WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:241
> + if (currentExpectedImageTest == currentActualImageTest &&
> + currentExpectedImageTest == testName) {
Nit: WebKit style is to put the && on the left of the second line.
More information about the webkit-reviews
mailing list