[webkit-reviews] review denied: [Bug 49366] [Chromium][DRT] EventSender.contextClick() should aware spellchecking : [Attachment 74089] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 49366: [Chromium][DRT] EventSender.contextClick() should aware
spellchecking
https://bugs.webkit.org/show_bug.cgi?id=49366

Attachment 74089: Patch
https://bugs.webkit.org/attachment.cgi?id=74089&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74089&action=review

> WebKitTools/DumpRenderTree/chromium/EventSender.cpp:756
> +	   for (int i = 0; i < suggestions.size(); ++i) 

"i" should be unsigned.

> WebKitTools/DumpRenderTree/chromium/MockSpellCheck.cpp:95
> +void MockSpellCheck::fillSuggestionList(const WebString& word,
> +					   Vector<WebString>* suggestions)

nit: no need to break the line

> WebKitTools/DumpRenderTree/chromium/MockSpellCheck.h:66
> +    void fillSuggestionList(const WebKit::WebString& word,
> +			       Vector<WebKit::WebString>* suggestions);

nit: no need to break the line