[webkit-reviews] review denied: [Bug 49366] [Chromium][DRT] EventSender.contextClick() should aware spellchecking : [Attachment 74087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 17 01:05:16 PST 2010


Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 49366: [Chromium][DRT] EventSender.contextClick() should aware
spellchecking
https://bugs.webkit.org/show_bug.cgi?id=49366

Attachment 74087: Patch
https://bugs.webkit.org/attachment.cgi?id=74087&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74087&action=review

> LayoutTests/ChangeLog:9
> +	   - Added a test for improve the coverage.
> +	   - Unskipped one passed test.

Do not do two things in one patch.  Adding a test (not Chromium-specific)
should be separated from the DRT change (Chromium-specific).

>
LayoutTests/editing/spelling/script-tests/context-menu-suggestions-for-selectio
n.js:51
>  \ No newline at end of file

Add a line-break.

> LayoutTests/platform/chromium/test_expectations.txt:696
> -// Need to dump context menu items on eventSender.contextClick(true).
> -BUGWK39105 : editing/spelling/context-menu-suggestions.html = TEXT
> +// Need to enable mock spellchecker. see Bug 45633
> +BUGWK45633 WIN LINUX : editing/spelling/context-menu-suggestions.html = TEXT


The DRT change is DRT-only.  So test_shell still fail with it, right?


More information about the webkit-reviews mailing list