[webkit-reviews] review granted: [Bug 49634] Make overflow guards in WTF::String::utf8 explicit : [Attachment 74071] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 18:01:27 PST 2010


Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 49634: Make overflow guards in WTF::String::utf8 explicit
https://bugs.webkit.org/show_bug.cgi?id=49634

Attachment 74071: Patch
https://bugs.webkit.org/attachment.cgi?id=74071&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=74071&action=review

> JavaScriptCore/wtf/text/WTFString.cpp:700
> +    if (length > numeric_limits<unsigned>::max() / 3)

If we changed the type of the local variable length to size_t instead of
unsigned, then this could just check against size_t instead of unsigned, giving
us a higher limit on 64-bit platforms.


More information about the webkit-reviews mailing list